Repository navigation
message.jq: don't escape markdown in linked titles; refactor for readability - #21
Merged
Merged
Conversation
Discord doesn't apply backslash escapes inside masked link text, so escaped titles showed literal backslashes, e.g. `\[Fixes\]` or `labeler\_id`. Titles are now linked as-is. Discord refuses to link text containing URLs, @everyone/@here, raw mentions, or an unclosed bracket, so those titles fall back to escaped plain text with only the number linked. Fixes #16
Name the colors and Discord component constants, pass message fields as an object instead of six positional arguments, and split each event into its own function. Output is unchanged; verified byte-for-byte against the previous version with jq 1.6 and 1.8.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord doesn't apply backslash escapes inside masked link text, so our escaped titles included literal backslashes. Oops. Let's stop doing that.
When experimenting with this fix, I found that Discord also refuses to link text containing URLs, @-everyone/@-here mentions, raw mentions, or unclosed brackets; in those cases, we drop the link (to prevent ugly Markdown) and only link the more predictable suffix.
Aaaand then I was getting tired of how unreadble the jq was, so I refactored it to use constants, objects instead of positional arguments, and per-event functions. I think it's a whole lot more readable to humans, but I've verified that the resulting output is byte-for-byte identical.
Fixes #16