Repository navigation
Regexp pipeline - #4409
Merged
Merged
Regexp pipeline#4409
Conversation
…s of their strings
kddnewton
force-pushed
the
regexp-pipeline
branch
from
November 18, 2026 14:51
8290caa to
7426040
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a full overhaul of the way we parse regular expressions.
For the uninitiated, you have to parse regular expressions in Ruby because named captures can introduce local variables, and an identifier being a local variable can change the way an expression is lexed. As such, we have to get this right.
Previously we got just enough working to get the CRuby specs to pass, but left a lot on the table. In particular we did not match a lot of Onigmo validation, and as such a lot of things that should have been parse time errors ended up being compile time errors. Not a huge difference for a lot of people, but much worse from the perspective of tooling.
This stack of commits brings a lot of Onigmo's frontend validation into Prism, and gets us largely to parity. It also cleans up a fairly large number of small, difficult to hit bugs in edge cases. The remaining disparities are mostly tiny, and I've opened up redmine tickets for almost all of them. The only other one that isn't really an issue per-se but is something I'm intentionally leaving out of this is validating \p{} syntax, because I don't want to take on the massive list of valid UCD properties.
Fixes #4398
Fixes #4399
Fixes #4400
Fixes #4401
Fixes #4402
Fixes #4403
Fixes #4404
Fixes #4405
Fixes #4406
Fixes #4407
Fixes #4408