Conversation
smortex
force-pushed
the
add-support-for-tlsa-rr
branch
from
October 2, 2026 00:46
bd19162 to
857715f
Compare
smortex
commented
Oct 2, 2026
Comment on lines
+2650
to
+2652
| @certificate_usage = certificate_usage.to_int | ||
| @selector = selector.to_int | ||
| @matching_type = matching_type.to_int |
Author
There was a problem hiding this comment.
I am not sure if adding bound checks here is desirable (RFC6698 list acceptable values in section 2.1). Advices are welcome!
smortex
commented
Oct 2, 2026
| @certificate_usage = certificate_usage.to_int | ||
| @selector = selector.to_int | ||
| @matching_type = matching_type.to_int | ||
| @certificate_association_data = certificate_association_data |
Author
There was a problem hiding this comment.
I am also not sure about the internal representation to use for this piece of information.
I chose a hex string representation to match what dig(1) outputs, but will be happy to adjust it on request.
Add support for TLSA resource records as defined in [RFC6698]. [RFC6698]: https://www.rfc-editor.org/info/rfc6698
smortex
force-pushed
the
add-support-for-tlsa-rr
branch
from
October 2, 2026 00:56
857715f to
3c0a1e5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for TLSA resource records as defined in RFC6698.