Skip to content

fix color scheme with the Rust theme - #3230

Merged
GuillaumeGomez merged 3 commits into
rust-lang:mainfrom
pinage404:fix_color_scheme
Oct 5, 2026
Merged

GuillaumeGomez merged 3 commits into
rust-lang:mainfrom
pinage404:fix_color_scheme

Conversation

@pinage404

Copy link
Copy Markdown
Contributor

Hello,

When using light-dark() in CSS, it works great with all theme but not with the Rust theme

Others themes have the variable --color-scheme set to light or dark but the Rust theme don't have this variable

Before After
Screenshot 2026-09-27 at 13-26-19 Foo - Blog - pinage404 Screenshot 2026-09-27 at 13-26-37 Foo - Blog - pinage404

Using this file :

<style>
    main {
        background-color: light-dark(white, black);
        color: light-dark(black, white);
    }
</style>

# title

Some content

I manually checked many pages, i don't see regression, i don't see changes if i don't use ligth-dark()

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Sep 27, 2026

@GuillaumeGomez GuillaumeGomez left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Please add a GUI test for it

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: waiting on a review labels Oct 1, 2026
@rustbot

rustbot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@GuillaumeGomez GuillaumeGomez left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the missing GUI test.

View changes since this review

@GuillaumeGomez
GuillaumeGomez added this pull request to the merge queue Oct 5, 2026
@GuillaumeGomez
GuillaumeGomez removed this pull request from the merge queue due to a manual request Oct 5, 2026
@pinage404

Copy link
Copy Markdown
Contributor Author

Thanks =D

@GuillaumeGomez
GuillaumeGomez added this pull request to the merge queue Oct 5, 2026
Merged via the queue into rust-lang:main with commit d465899 Oct 5, 2026
20 checks passed
@pinage404
pinage404 deleted the fix_color_scheme branch October 5, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants