Repository navigation
Fix GUI test runner on Windows - #3234
Open
kartik-py12 wants to merge 1 commit into
Open
kartik-py12 wants to merge 1 commit into
kartik-py12 wants to merge 1 commit into
Conversation
`cargo test --test gui` fails on Windows for a few reasons:
* `npm` and `npx` are batch files there, so `Command::new("npm")` cannot
find them.
* The `browser-ui-test` version was read from the second `:`-separated
field of `npm list --parseable --long`, which is part of the path when
it starts with a drive letter.
* `DOC_PATH` was `file://` followed by a path with backslashes, which does
not match the `file:///C:/...` location the browser reports in
`redirect.goml`.
Fixes rust-lang#3067
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3067.
cargo test --test guifails on Windows before any test runs:npmandnpxare batch files there, soCommand::new("npm")can't find them.browser-ui-testversion was read from the second:-separated field ofnpm list --parseable --long, which is part of the path when it starts with a drive letter.DOC_PATHwasfile://plus a path with backslashes, which doesn't match thefile:///C:/...location the browser reports inredirect.goml.This fixes all three. Behavior on other platforms is unchanged.
I ran the suite on a GitHub Actions
windows-latestrunner and it now builds and runs. A couple of timing-sensitive tests (redirect,heading-nav-collapsed) fail intermittently on those runners. That is independent of this change.