Repository navigation
narrow nix/ipc-channel/capstone deps to x86 targets - #5391
Merged
Merged
Conversation
Member
|
Why would we want to have unused dependencies in Miri? |
Contributor
Author
|
ohh i forgot to put that in the commit. because capstone and nix are used only on x86 targets miri/src/shims/native_lib/mod.rs Lines 21 to 29 in 2f577e1 |
Member
|
Is it not possible to restrict these dependencies to only those targets then? |
Member
|
I assume this Line 43 in 2f577e1 just needs to be restricted to "x86 only". (And GNU only apparently.) |
fneddy
force-pushed
the
fix_check_non_x86
branch
from
October 6, 2026 09:11
c7d9b21 to
d615b15
Compare
These three dependencies are only used on x86 targets causing `cargo::unused_dependencies` warnings on other architectures.
fneddy
force-pushed
the
fix_check_non_x86
branch
2 times, most recently
from
October 6, 2026 09:15
d615b15 to
7c1dee0
Compare
Member
|
Thanks :) |
RalfJung
force-pushed
the
fix_check_non_x86
branch
from
October 6, 2026 10:00
e2847a0 to
70c6638
Compare
RalfJung
enabled auto-merge
October 6, 2026 10:00
RalfJung
force-pushed
the
fix_check_non_x86
branch
from
October 6, 2026 10:48
70c6638 to
7c1dee0
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cargo::unused_dependencieslint was recently added to Cargo and defaults towarn. Because bootstrap setsCARGO_BUILD_WARNINGS=denyfor in-tree builds, this new default warning becomes a hard error.This change silence the lint the same way we already do in other places.