feat(rc-admin)!: add bounded diagnostic snapshots#285
Draft
cxymds wants to merge 1 commit into
Draft
Conversation
BREAKING CHANGE: Adds new protected rc admin diagnostics command contracts and three output-v3 family enum values. Existing output-v1/v2 records and existing v3 families are unchanged; consumers opt in by invoking the new commands.
cxymds
changed the base branch from
cxymds/issue-1403-diagnostic-capabilities
to
main
July 21, 2026 16:55
cxymds
changed the base branch from
main
to
cxymds/issue-1403-diagnostic-capabilities
July 21, 2026 16:55
Member
Author
|
Validation is complete for exact head Local gates:
Focused validation:
Remote gates:
The draft PR is open and its true stacked base is restored to A local live beta.10 container run was not performed because the Docker daemon is unavailable in this workspace; the validation claim is limited to the source-backed contract audit, mocks, local suites, and GitHub checks above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes rustfs/backlog#1400
Stacked on #282 (
cxymds/issue-1403-diagnostic-capabilities).Background and user impact
RustFS beta.10 exposes authenticated health information, a v4 cluster snapshot, and an extension catalog, but
rcdid not provide bounded typed commands for those routes. Route presence alone is insufficient: unknown server versions must remain fail-closed unless a read-only route is successfully confirmed, malformed/partial telemetry must not become a zero-valued success, andsnapshot: nullmust remain distinct from a missing response field.Solution
rc admin diagnostics health|cluster|extensions ALIAS./v3/infoand all three v4 discovery reads.Availableon unknown versions while keeping health conservative.snapshot: nullasinitializing_or_unavailable, never healthy.health_snapshot,cluster_snapshot, andextension_catalog.BREAKING contract note
BREAKING: This PR updates the protected
docs/reference/rc/behavior contract and adds three output-v3 enum values for new commands. It does not change output v1/v2, config schema, exit-code definitions, or existing command behavior. Migration is opt-in: consumers only see the new schemas when invoking the new diagnostics commands.Validation
Exact head:
1fb67e15de3f1bb300b110afe3d9864c752e5ccecargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceLimitations
mc support diagarchive parity.