fix(rm): delete versions with explicit version IDs#293
Draft
overtrue wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Refs rustfs/rustfs#5104.
Refs rustfs/backlog#1405.
Blocked full bucket cleanup dependency: rustfs/backlog#1384.
Background
The initial removal-flag implementation made
rm --versionsandrb --forcerely on the RustFS-specificx-rustfs-force-deleteheader. That collapses all versions of a key into one opaque server operation, loses per-version results, and cannot provide the staged discovery and failure guarantees required by backlog #1405.Changes
DeleteObjectsrequests with explicitVersionIdvalues for versions and delete markers.DeleteMarkerVersionIdin delete results so delete-marker cleanup is tracked correctly.--purgeoption.rb --forceandrb --dangerousbefore alias or network resolution until safe bucket-wide multipart discovery is available.Scope
This PR does not claim to complete
rb --force. The full staged workflow remains tracked by rustfs/backlog#1405 and is blocked by rustfs/backlog#1384. The existing explicitrm --purgebehavior remains unchanged.Validation
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace