fix(status): separate cluster diagnostic states#177
Merged
Conversation
cxymds
marked this pull request as ready for review
July 22, 2026 00:41
houseme
approved these changes
Jul 22, 2026
Contributor
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ef05c57d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separates running-status diagnostics into independent peer health, storage readiness, usage freshness, listing/metacache, and workload-admission states.
The previous status model could conflate unavailable peer diagnostics with node or disk failures. This change consumes the optional backend-discovered cluster snapshot, preserves legacy status data for older servers, and prevents diagnostic endpoint timeouts from blocking the page.
The follow-up contract from rustfs/backlog#1392 is now reflected directly:
snapshot.components.*.conditionis authoritative over nested capability statusunknown,not_reported,stale, anddegradedremain distinct statesinternode_stall_timeouts_totalis displayed as cumulative historical evidence and never changes current listing health by itselfwalk_dirmetrics verification flowType of Change
Testing
pnpm install --frozen-lockfile pnpm tsc --noEmit pnpm lint pnpm prettier --check . pnpm test:runAll 349 tests pass. The local Console route was started successfully, but end-to-end visual verification was blocked by the unavailable authenticated RustFS backend; semantic, responsive, old-backend fallback, and exact component-contract regression tests cover the changed behavior.
Checklist
Related Issues
Closes rustfs/backlog#1391
Closes rustfs/backlog#1392
Screenshots (if applicable)
Not included because the local backend session was not authenticated.
Additional Notes
The optional cluster snapshot request has an independent five-second timeout and never blocks the legacy status requests. Historical stall counters are deliberately presented without a current-health inference.