fix: add dark mode support for charts page#17
Open
overtrue wants to merge 1 commit into
Open
Conversation
Add prefers-color-scheme: dark media query with GitHub dark theme colors so text is readable when system is in dark/night mode. - Load github-markdown-dark.min.css conditionally via media query - Override all CSS custom properties for dark mode - Set data-color-mode=auto so github-markdown-css dark styles activate - Cover headings, code blocks, tables, blockquotes, hr, quick-install panel
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
helm | f9c2f33 | Jul 20 2026, 02:16 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Text is invisible/unreadable on https://charts.rustfs.com/ when system is in dark mode. The page only defines light CSS variables, and
data-color-modeis hardcoded tolight.Fix
github-markdown-dark.min.cssconditionally viaprefers-color-scheme: darkmedia query@media (prefers-color-scheme: dark)block overriding all CSS custom properties (backgrounds, text, borders, code blocks, links)data-color-mode="auto"on<body>sogithub-markdown-cssdark selectors activateVerification