Repository navigation
Conversation
ruff's target-version said py38, but CI tests only 3.10 and main already needs 3.10 (match statement in lib/asr_results.py). Raise it to py310 and apply the resulting ruff 0.11.8 formatting (parenthesized multi-item with statements; layout only). Also set apptek_hashes.yml to 3.10.12 for consistency with the other workflows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.tomlsets ruff'starget-version = "py38". That is the only place in the repository that states a Python version: there is norequires-python,setup.pyorsetup.cfg, and README, CONTRIBUTING anddocs/don't mention one. But neither the CI nor the code matches it:tests.ymlandhashes.ymlrun on Python 3.10.12. (ruff.ymluses 3.13 to install ruff;apptek_hashes.ymlsets up 3.8 but runs onlycurl/jqto start the Bitbucket pipeline, so its Python version doesn't matter.)lib/asr_results.py(Add library for reading/writing new ASR result format #633) has amatchstatement, which is aSyntaxErrorbefore 3.10, and usesstr | PathLikeandlist[...]annotations withoutfrom __future__ import annotations.text/csv.py(Add job to get columns from csv file #643) uses an unguardedlist[int]annotation, which needs 3.9.This PR changes the ruff target to
py310, so the stated version matches what is tested and what the code already requires. For consistency, it also setsapptek_hashes.ymlto 3.10.12 like the other workflows. That workflow doesn't run Python, so nothing changes in what it does.Formatting. With
target-version = "py310", ruff 0.11.8 (the version CI pins) formats multi-itemwithstatements using parenthesized context managers, a 3.10 feature. Six files are rewritten this way:corpus/filter.py,corpus/segments.py,fairseq/manifest.py,lexicon/conversion.py,lm/vocabulary.pyandtext/info.py. The changes are layout only and live insiderun()bodies, so no behaviour, constructor argument or job hash changes. Without them, theruffcheck would fail on this PR.— Claude Code
🤖 Generated with Claude Code