Repository navigation
Fix multiple issues with ASR-results writing - #678
Merged
Merged
Conversation
…nsistency, merge recording revisits - write_asr_results: always write the `type` discriminator, so results built in Python can be parsed back. Output for records that already carried `type` is unchanged byte for byte. - parse_asr_results: sort segments without n_best_index first (stable) instead of raising TypeError. - A speaker id must always come with the same name and gender within one results file; stream/parse/write raise ValueError otherwise. - parse_asr_results merges a recording name that appears again into the first BatchRecording of that name; a different path raises ValueError. - Run tests/lib in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Without it, pytest's rootdir-based import puts tests/lib/ itself on sys.path instead of the directory containing the i6_core checkout, so collecting tests/lib/test_asr_results.py fails with ModuleNotFoundError: No module named 'i6_core'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
curufinwe
assigned
curufinwe,
michelwi,
hannah220,
SimBe195 and
robin-p-schmitt and unassigned
curufinwe
hannah220
approved these changes
Nov 5, 2026
SimBe195
approved these changes
Nov 5, 2026
curufinwe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_asr_resultsdropped thetypediscriminator for records built in Python (it was only a default, soexclude_unsetremoved it), soparse_asr_resultscould not read the file back.typeis now always written. Output for records that already carriedtypeis unchanged byte for byte.parse_asr_resultsraisedTypeErrorwhen several alternatives of a segment had non_best_index, or only some did. Segments without an index now sort first, in input order.stream_asr_results,parse_asr_resultsandwrite_asr_resultsraiseValueErrorotherwise.BatchRecordingof that name. A differentpathraisesValueError.tests/libto the CI test matrix, so these tests actually run.No i6_core job uses this module, so no hashes are affected.
🤖 Generated with Claude Code