Skip to content

test: synchronize image rendering PTY output #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanfowler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: synchronize image rendering PTY output #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/support/terminal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ pub(crate) fn run_image_render_pty(env: Vec<(String, String)>) -> String {
}
configure_pty_child(&mut cmd, &pty.slave);
let mut child = cmd.spawn().expect("spawn fetch under PTY");
// Close the parent-owned slave handles so the capture thread can observe
// EOF after the child exits.
drop(cmd);
drop(pty.slave);
let capture = start_pty_capture(&pty.master);
let status = wait_child(&mut child, Duration::from_secs(3))
Expand All @@ -88,10 +91,8 @@ pub(crate) fn run_image_render_pty(env: Vec<(String, String)>) -> String {
"fetch exited with {status}; PTY output:\n{}",
capture.output()
);
let output = capture.output();
drop(pty.master);
capture.close();
output
capture.finish()
}

#[cfg(unix)]
Expand Down
Loading