Repository navigation
fix(release): create the GitHub release when the image jobs were skipped - #278
Merged
earakely-scale merged 1 commit intoOct 21, 2026
Merged
Conversation
The release job had the default condition, which skips a job whenever any job upstream of it was skipped. Since the image jobs joined the workflow, they are skipped on every release that publishes no new image, so v0.9.1337 to v0.9.1340 reached PyPI with no GitHub release. It now runs whenever the framework job published, as the framework job already does after skipped image jobs. The next release's notes start from v0.9.1336, the newest tag with a release, so they list the pull requests of the releases that got none. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
earakely-scale
deleted the
fix/release-job-runs-after-skipped-image-jobs
branch
October 21, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.9.1337 to v0.9.1340 reached PyPI but have no GitHub release; the newest is v0.9.1336. In each of those runs,
frameworksucceeded andreleasewas skipped.releasehad the default condition,success(), which skips a job whenever any job upstream of it was skipped. Since the image jobs joined the workflow, they're skipped on every release that publishes no new image. That's every release beforePUBLISH_INFRA_IMAGESwas set, and v0.9.1340 because its images were already published.frameworkalready has an explicit condition that tolerates skipped image jobs, so PyPI publishing was never affected.releasenow runs wheneverframeworksucceeded (!cancelled() && needs.framework.result == 'success'). A run by hand still skips it, becauseframeworkdoesn't run then. A new test pins the condition.The notes step starts from the newest earlier tag that has a release, v0.9.1336. So the next release's notes list the pull requests of v0.9.1337 to v0.9.1340 too.
This PR carries
bump-version, so its own release checks the fix. Creating release pages for v0.9.1337 to v0.9.1340 by hand would be a separate step.🤖 Generated with Claude Code
The PR appears safe to merge.Summary
The
releasejob can now run after skipped image jobs, providedframeworksucceeded and the run was not cancelled.frameworksucceeds.Reviews (1) · Last reviewed commit: "fix(release): create the GitHub release ..." · Reviewed by Greptile