Fix load_example_data for non-editable installs by bundling datasets/ into the wheel - #467
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
+ Coverage 85.87% 86.05% +0.17%
==========================================
Files 15 15
Lines 1274 1276 +2
==========================================
+ Hits 1094 1098 +4
+ Misses 180 178 -2
🚀 New features to boost your workflow:
|
…itable installs load_example_data() located the bundled example data via Path(pydeseq2.__file__).parents[2], which only resolves to the repo root for an editable, src-layout checkout. A regularly installed (non-editable) wheel has no such parent directory, so the scverse integration-testing CI, which installs PyDESeq2 as a normal dependency, hit a FileNotFoundError (#464-466). Now the datasets/ directory is force-included into the wheel next to the package, and load_example_data() prefers that package-adjacent copy, falling back to the repo-root-relative path for editable checkouts.
Zethson
force-pushed
the
fix-datasets-path-in-wheel
branch
from
September 7, 2026 15:40
e81c3d5 to
f9ebb78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #464, closes #465, closes #466.
load_example_data()located the bundled example data viaPath(pydeseq2.__file__).parents[2], which only resolves to the repo root for an editable, src-layout checkout — a normally installed (non-editable) wheel has no such parent, which is why the scverse integration-testing CI hitFileNotFoundError. Nowdatasets/is force-included into the wheel next to the package, andload_example_data()prefers that package-adjacent copy, falling back to the repo-root-relative path for editable checkouts.