Skip to content

ci: move onto the seidroid review workflow, retire ai-review - #353

Closed
bdchatham wants to merge 1 commit into
mainfrom
chore/remove-old-ai-review
Closed

bdchatham wants to merge 1 commit into
mainfrom
chore/remove-old-ai-review

Conversation

@bdchatham

Copy link
Copy Markdown

Summary

This PR replaces the old AI review with seidroid. That is the same move sei-chain (#4372), sei-load (#92), sei-internal-skills (#416) and platform (#1652) made.

  • Removed: .github/workflows/ai-review.yml, the caller of the old three-pass review in uci (ai-review.yml).

  • Added: .github/workflows/seidroid.yml. It calls uci seidroid-review.yml at v0.0.26 (0dc48cf) with the same triggers and jobs as sei-chain: review, close (anchored) and reclaim on close.

  • Why both cannot stay: uci says seidroid-review replaces ai-review. If both run, every PR gets two reviews. A comment with @seidroid review and more text also starts the old review path.

  • What stays: ai-assist.yml (the @seidroid assistant) and every other workflow.

  • Not set: approve-on-success. The repo owners can turn on bot approval on a clean review if they want it.

Before merge: a repo admin must add the repository secret OMNIGENT_MACHINE_CLIENT_SECRET (the seidroid machine credential, the same as in sei-chain). This repo does not have it, so without it every seidroid review fails. The GitHub App secrets PLATFORM_CODE_AGENT_APP_ID and PLATFORM_CODE_AGENT_APP_PK are already available.

How to use it

To ask for a review, post a comment whose whole body is @seidroid review. The assistant answers any other comment that mentions @seidroid.

Verification

  • actionlint passes on seidroid.yml.
  • No branch protection rule or ruleset on the default branch requires the AI Review check. seidroid also publishes an AI Review check run by default.

🤖 Generated with Claude Code

Replace the uci ai-review.yml caller with a seidroid.yml caller of uci
seidroid-review.yml at v0.0.26, the same wiring sei-chain uses. uci says
seidroid-review replaces ai-review and the two must not run side by side.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Swaps the PR review automation path and requires a new repo secret; reviews fail until OMNIGENT_MACHINE_CLIENT_SECRET is set, and fork PRs cannot auto-reclaim sandboxes on close.

Overview
Replaces automatic PR AI review with on-demand Seidroid review, aligned with other sei-protocol repos.

Deletes .github/workflows/ai-review.yml, which ran the legacy uci ai-review workflow on every PR open/sync/label change. Adds .github/workflows/seidroid.yml, which wires three reusable uci seidroid-review jobs (v0.0.26): review on PR lifecycle events or when someone posts @seidroid review (issue, inline, or review body), close when a top-level comment starts with @seidroid review close, and reclaim when the PR is closed. Reviews are gated to sei-protocol/sei-core and use PLATFORM_CODE_AGENT_* app secrets plus a new OMNIGENT_MACHINE_CLIENT_SECRET (must be configured before reviews succeed).

ai-assist.yml and other workflows are unchanged; approve-on-success is not enabled in this wiring.

Reviewed by Cursor Bugbot for commit 8550a0d. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (b7f4e54) to head (8550a0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          81       81           
  Lines        5652     5652           
=======================================
  Hits         5529     5529           
  Misses        123      123           
Flag Coverage Δ
mcp-server 96.92% <ø> (ø)
precompiles 100.00% <ø> (ø)
registry 100.00% <ø> (ø)
sei-global-wallet 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bdchatham

Copy link
Copy Markdown
Author

Closing this: it is out of scope. We remove the old AI review only from the core packages that already run seidroid, and those have no ai-review.yml left. This repository does not run seidroid, so it keeps its current review.

@bdchatham bdchatham closed this Oct 1, 2026
@bdchatham
bdchatham deleted the chore/remove-old-ai-review branch October 1, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants