fix: SSH remote ping uses same args as Exec; remove debug traces - #143
Merged
Conversation
Root cause of sessions disappearing after restart: other ccx processes (running concurrently) each call cleanupStaleRemoteSessions + pollRemotePhasesCmd, racing on the shared remote-sessions.yaml file. When multiple ccx instances ping the same SSH host, one fails and writes [], clobbering the session added by another instance. Fixes: - SSH Prepare/Status use the same SSH args as Exec (no BatchMode, with keepalive) so the ping succeeds on macOS where BatchMode=yes hangs with the launchd SSH agent. - Debug traces removed from persist.go. - Verified: with a single ccx process, the SSH session persists across restart and survives the 30s poll cycle.
jinsekim
added
the
auto-review/approved
Kairo-Kim
approved these changes
Jul 25, 2026
mitrilmad
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of sessions disappearing after restart: other ccx processes running concurrently each call cleanupStaleRemoteSessions + pollRemotePhasesCmd, racing on the shared remote-sessions.yaml file. One ccx instance's failed SSH ping writes [], clobbering the session added by another.
Fixes:
go build/vet clean; go test ./... green (except pre-existing TestNewAppDefaults failure).