Skip to content

Add custom allocator support to Vec/Box conversions #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejandro-vaz merged 10 commits into from
Oct 8, 2026
Merged

Add custom allocator support to Vec/Box conversions #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c9c23b
Add custom allocator support to Vec/Box conversions
bolshoytoster Oct 5, 2026
63cbe5d
Actually deallocate vec when moving it inline
bolshoytoster Oct 5, 2026
481092d
into_raw_parts isn't in MSRV‽
bolshoytoster Oct 5, 2026
727c235
Draft internal Parts trait and vec conversion helpers
bolshoytoster Oct 5, 2026
41e4f7f
Comment style
bolshoytoster Oct 5, 2026
8374164
Don't try to deallocate a dangling pointer
bolshoytoster Oct 5, 2026
20a03c9
Fix MSRV compatibility
bolshoytoster Oct 5, 2026
d65d857
Correct deprecation version
bolshoytoster Oct 6, 2026
e425125
Remove all but deprecation
bolshoytoster Oct 8, 2026
f5645b6
Merge branch 'v2' into v2
bolshoytoster Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/conversions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ impl<Item: Clone, const INLINE: usize> From<&[Item]> for SmallVec<Item, INLINE,
fn from(slice: &[Item]) -> Self {
if slice.len() > Self::inline_size() {
// Standard Rust vectors are already specialized.
Self::from_vec(Vec::from(slice))
Vec::from(slice).into()
} else {
// SAFETY: The precondition is checked in the initial comparison
// above.
Expand Down Expand Up @@ -153,6 +153,6 @@ impl<Item, const INLINE: usize, Heap: Allocator> From<SmallVec<Item, INLINE, Hea

impl<T, const N: usize> From<Box<[T]>> for SmallVec<T, N> {
fn from(boxed: Box<[T]>) -> Self {
Self::from_vec(boxed.into_vec())
boxed.into_vec().into()
}
}
3 changes: 2 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ impl<Item, const INLINE: usize> SmallVec<Item, INLINE, Global> {
}

#[inline]
#[deprecated(since = "2.0.0-beta.3", note = "use `From::<Vec<T>>::from` instead")]
pub fn from_vec(vec: Vec<Item>) -> Self {
if vec.capacity() == 0 {
return Self::new();
Expand Down Expand Up @@ -1524,7 +1525,7 @@ pub fn from_elem<Item: Clone, const INLINE: usize>(
) -> SmallVec<Item, INLINE, Global> {
if n > SmallVec::<Item, INLINE>::inline_size() {
// Standard Rust vectors are already specialized.
SmallVec::from_vec(vec![elem; n])
vec![elem; n].into()
} else {
#[cfg(feature = "specialization")]
{
Expand Down
Loading