Repository navigation
fix(ui): widen scrollbar thumbs, drop the line beside the editor's - #989
Merged
Merged
Conversation
The editor's thumb filled its 10px track before #978 and rests at 6px since, thinner than Windows' 9px. Both thumbs now rest at 8px and grow to 12px on a 14px track. The overview ruler's border drew a 1px line down the editor scrollbar's left edge, so it is off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Follows #978. @gooker said in #979 the scrollbars are still too thin, and the editor's scrollbar had a stray vertical line down its left edge. Both thumbs now rest at 8px and grow to 12px on a 14px track, and the line is gone.
Mechanism
Before #978 the editor set only
verticalScrollbarSize: 10. Monaco defaults the slider size to the scrollbar size, so the thumb filled the track at 10px. #978 setverticalSliderSize: 6, which made the editor's resting thumb thinner than before. The preview went from 4px to 6px.For reference, measured or read from source:
NativeThemeFluent)macOS can rest at 6px because its overlay bars hide when idle. Markpad's are always visible, so 8px sits between the Windows and macOS thumbs.
The line is the overview ruler's border. The ruler lies under the vertical scrollbar, and
overviewRulerBorderdefaults to true, drawing a 1pxeditorOverviewRuler.borderline at its left edge. It is now off. The ruler's marks stay.Verification
npm audit(0 vulnerabilities),npm run check(0 errors),npm test(1122 pass),npx vitest run(512 pass). In Chromium with Monaco 0.55.1, column 0 of the overview ruler canvas was painted on all 600 rows with the border on and on none with it off. The slider measured 8px at rest at left 3 and 12px when active at left 1 in the 14px track. The preview thumb is computed from the CSS (14px minus a 3px or 1px border on each side), not measured. Not checked in WKWebView or WebView2.