refactor(ui): use generic Breadcrumb in install key history page - #6864
Merged
Conversation
Replace the ad-hoc back-link with the shared `Breadcrumb` component, gaining proper `nav` landmark, `aria-current="page"`, and chevron separators for free.
|
Claude finished @luizhf42's task in 49s —— View job Code Review CompleteReviewed 1 file across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is. The swap from the hand-rolled If you push additional changes and want a new review, tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The install key history page had a hand-rolled back-link (
<Link>+ArrowLeftIcon). Replaced it with the sharedBreadcrumbcomponent so the page gets a proper<nav>landmark,aria-current="page"on the leaf, and chevron separators — matching every other detail page that already usesBreadcrumb.Changes
InstallKeyHistoryPage: swapped the ad-hoc<Link>for a two-segmentBreadcrumb("Install Keys" → key display name) and dropped the now-unusedLinkandArrowLeftIconimports