[docker] Fix ERLANG_EXITS typo in healthcheck script - #3130
Open
jacky-w-j-li wants to merge 1 commit into
Open
jacky-w-j-li wants to merge 1 commit into
jacky-w-j-li wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker healthcheck script
docker/base_image/healthcheck.shcontains a variable name typo:ERLANG_EXITSshould beERLANG_EXIST.Root cause
Line 35 assigns the variable as
ERLANG_EXITS, and line 37 references it as$ERLANG_EXITS. While the script is internally consistent (the same misspelled name is used in both places, so the script works), the name is clearly intended to beERLANG_EXISTto match the sibling variableKAZOO_EXISTon line 34, and to reflect the actual meaning (checking whether the module exists).Fix
Rename
ERLANG_EXITStoERLANG_EXISTin both the assignment (line 35) and the conditional check (line 37).Testing
Resolves: #3126