[core] Preserve confirmed blind transfers with bypass media - #3166
Open
esukanovic wants to merge 2 commits into
Open
esukanovic wants to merge 2 commits into
esukanovic wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
confirm_blind_transferwas introduced in 07204a1 to keep the transferor leg alive until the transfer succeeds or fails.With
bypass_media,switch_ivr_session_transfer()still unconditionally hangs up that leg.The confirmation flag must be checked as both active and pending because Sofia sets it as a state flag and immediately starts the transfer. Depending on whether the state transition has completed, checking only the active flag can miss it and incorrectly hang up the transferor.
Media restore is performed asynchronously because a synchronous restore during REFER handling blocks the signal-data thread from processing the re-INVITE
200 OK, delaying the ACK until timeout.Type of Change
Related Issues
Testing
Checklist
Additional Notes