Conversation
The deflect handler prefixed `sip:` and appended the profile address to any
target not starting with `sip:`. `tel:`, `sips:` and other URIs went out as
`sip:tel:...@<ip>`. A name-addr target, as a proxied `Refer-To` or
`${sip_refer_to}` passes it, went out as `sip:<sip:...>@<ip>`, or was not sent
at all when it carried a display name, URI params or `?Replaces=`.
`sofia_deflect_build_refer_to()` now builds the `Refer-To`:
- a target that has a URI scheme or contains `<` goes out as given
- `user@host`, with or without a host port, only gains the `sip:` scheme
- a bare user or number is addressed at the profile, as before
- an empty or `NULL` target, which the `deflect` app passes when run without
data, is rejected; the handler logs it and sends no REFER
Adds `test_sofia_deflect_build_refer_to` to `test_sofia_funcs`: rejected
targets, bare users with IPv4 and IPv6 profile addresses, `user@host` forms,
URIs with a scheme, name-addr forms, the known limitations and truncation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deflect handler prefixed
sip:and appended the profile address to any target not starting withsip:.tel:,sips:and other URIs went out assip:tel:...@<ip>. A name-addr target, as a proxiedRefer-Toor${sip_refer_to}passes it, went out assip:<sip:...>@<ip>, or was not sent at all when it carried a display name, URI params or?Replaces=.sofia_deflect_build_refer_to()now builds theRefer-To:<goes out as givenuser@host, with or without a host port, only gains thesip:schemeNULLtarget, which thedeflectapp passes when run without data, is rejected; the handler logs it and sends no REFERAdds
test_sofia_deflect_build_refer_tototest_sofia_funcs: rejected targets, bare users with IPv4 and IPv6 profile addresses,user@hostforms, URIs with a scheme, name-addr forms, the known limitations and truncation.