Cut the continuous view's cost per navigation step - #235
Open
alex-rawlings-yyc wants to merge 1 commit into
Open
Cut the continuous view's cost per navigation step#235alex-rawlings-yyc wants to merge 1 commit into
alex-rawlings-yyc wants to merge 1 commit into
Conversation
Size the strip's render window to the viewport instead of a fixed 100 groups each side, keep the per-group and per-slot memoization from being defeated by per-render callback identities, read each phrase box's geometry once per arc pass, and resolve token-chip labels once per strip rather than per chip. An arrow press drops from ~790ms to ~100ms on an 8th-gen i5.
alex-rawlings-yyc
added
the
up next
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size the strip's render window to the viewport instead of a fixed 100 groups each side, keep the per-group and per-slot memoization from being defeated by per-render callback identities, read each phrase box's geometry once per arc pass, and resolve token-chip labels once per strip rather than per chip. An arrow press drops from ~790ms to ~100ms on an 8th-gen i5.
This change is