Convert the platform-parsed PT9 interlinear payload instead of raw XML - #272
Open
jasonleenaylor wants to merge 6 commits into
Open
Convert the platform-parsed PT9 interlinear payload instead of raw XML#272jasonleenaylor wants to merge 6 commits into
jasonleenaylor wants to merge 6 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 27, 2026
jasonleenaylor
marked this pull request as ready for review
August 27, 2026 20:48
The platformScripture.Pt9Interlinear projectInterface (paranext-core#2707) now serves PT9 interlinear data as parsed, PT9-parity models, so the converter consumes that payload directly: duplicate books resolve canonical-path-first from the served flags, lexicon joins use the served composed ids, and the extension's own XML parsers, their fixtures, and the fast-xml-parser dependency are removed. lexemeKey stays: PT9's composed lexeme id grammar still needs parsing on this side. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Two comments now say what the code does in its own terms: cluster classification derives from lexeme ids because PT9 persists no cluster type, and a bare-payload sense ref is attempted only when the defaults found across languages carry exactly one distinct sense id. Three behaviors a mutation could previously delete unnoticed are pinned: per-token and per-first-token analysis id numbering, no ref attempt on disagreeing default senses, and monotonic assignment of repeated phrase windows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Lexicon refs now name the authority that minted their ids (#269), so the test resolvers mint theirs under a declared test authority. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jasonleenaylor
force-pushed
the
pt9-parsed-converter
branch
from
August 27, 2026 23:04
42f0b13 to
8805469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume the parsed PT9 interlinear payload the platform now serves
(paranext/paranext-core#2707) instead of parsing raw XML in the extension.
First slice of the reworked PT9 import stack; supersedes #240.
duplicate books resolve canonical-path-first from the served filePath /
isCanonicalPath flags, and lexicon joins use the served composed entry ids.
fast-xml-parser dependency are removed; the platform reads the files with
PT9's own semantics. lexemeKey stays - PT9's composed lexeme id grammar
still needs parsing on this side.
This change is