Add FLEx semantic-domain fields to MiniLcm - #2536
Conversation
Map Abbreviation, Description, OcmCodes, and LouwNidaCodes through model, bridge, CRDT, and sync; keep Code as a convenience that prefers an explicit value then falls back to Abbreviation. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 27 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (39)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Update demo API types, align AutoFaker Code/Abbreviation for FwData round-trips, treat LCM missing-string marker as empty, and regenerate Verify/sena-3 snapshots for the new fields. Co-authored-by: Cursor <cursoragent@cursor.com>
Set Code on fixtures alongside Abbreviation so BeEquivalentTo no longer needs to exclude it. Co-authored-by: Cursor <cursoragent@cursor.com>
The first part of adding more fields to semantic domains, after this I want to add questions.
AI Summary
Summary
Abbreviation,Description,OcmCodes, andLouwNidaCodesto MiniLcmSemanticDomain, wired through FwData bridge, CRDT create/sync, normalization, and generated TS types.Codeas a UI/filter convenience: prefer an explicit Code (e.g. from FLEx), otherwise derive from Abbreviation; do not map Code back into Abbreviation.Test plan
dotnet test backend/FwLite/LcmCrdt.Tests --filter FullyQualifiedName~SemanticDomaindotnet test backend/FwLite/FwDataMiniLcmBridge.Tests --filter FullyQualifiedName~SemanticDomaindotnet test backend/FwLite/FwLiteProjectSync.Tests --filter FullyQualifiedName~UpdateDiffTests.SemanticDomaindotnet test backend/FwLite/MiniLcm.Tests --filter FullyQualifiedName~WriteNormalizationTeststask fw-lite:has-stale-generated-typesis clean after building FwLiteSharedMade with Cursor