Refactor writing system methods - #2567
Draft
hahn-kev wants to merge 4 commits into
Draft
Conversation
github-actions
Bot
added
the
💻 FW Lite
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem, the MiniLcmApi implementations are too big:
This is a first pass at setting a new pattern in an attempt to break up that up into smaller classes which are easier to read/write and reason about. At the end we might have a single class which just maps
IMiniLcmApito all of the implementing sub interfaces, but for now we will keep CrdtMiniLcmApi and FwDataMiniLcmApi and they will delegate internally, but tbd.One other thing I'm thinking about, is that it might not be beneficial to have the split of
IMiniLcmReadApi/IMiniLcmWriteApianymore (originally made for the LF implementation) as we would instead be split on Model, I don't like that we have a read and write version just for WritingSystems, that seems excessive now.