Skip to content

Fix SMT e2e tests - #1026

Merged
pmachapman merged 1 commit into
mainfrom
fix_e2e_tests
Aug 12, 2026
Merged

Fix SMT e2e tests#1026
pmachapman merged 1 commit into
mainfrom
fix_e2e_tests

Conversation

@pmachapman

@pmachapman pmachapman commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes the e2e SMT tests which were breaking on machine.py:latest due to the build options validation logic blocking the NMT build options which were specified for an SMT build.


This change is Reviewable

@pmachapman
pmachapman requested a review from Enkidu93 August 12, 2026 02:45
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.56%. Comparing base (f032547) to head (98d3767).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
- Coverage   72.58%   72.56%   -0.02%     
==========================================
  Files         391      391              
  Lines       21653    21653              
  Branches     2818     2818              
==========================================
- Hits        15717    15713       -4     
- Misses       4810     4814       +4     
  Partials     1126     1126              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman
pmachapman merged commit d0b78de into main Aug 12, 2026
2 checks passed
@pmachapman
pmachapman deleted the fix_e2e_tests branch August 12, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants