Skip to content

Only average scripture confidences for per-book confidence - #1034

Merged
Enkidu93 merged 1 commit into
mainfrom
scripture-only-confidences
Aug 20, 2026
Merged

Only average scripture confidences for per-book confidence#1034
Enkidu93 merged 1 commit into
mainfrom
scripture-only-confidences

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1033.


This change is Reviewable

@Enkidu93
Enkidu93 requested a review from pmachapman August 19, 2026 15:19
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.61%. Comparing base (43ffd54) to head (ce5e35b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
+ Coverage   72.59%   72.61%   +0.01%     
==========================================
  Files         391      391              
  Lines       21676    21677       +1     
  Branches     2820     2820              
==========================================
+ Hits        15735    15740       +5     
+ Misses       4814     4810       -4     
  Partials     1127     1127              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93
Enkidu93 merged commit e4c5c1e into main Aug 20, 2026
2 checks passed
@Enkidu93
Enkidu93 deleted the scripture-only-confidences branch August 20, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Book and chapter confidence scores are being calculated using non-verse confidence scores

3 participants