Add missing error messages to onboarding form - #3831
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3831 +/- ##
=======================================
Coverage 81.08% 81.08%
=======================================
Files 661 661
Lines 43058 43058
Branches 7036 7036
=======================================
Hits 34912 34912
Misses 6989 6989
Partials 1157 1157 ☔ View full report in Codecov by Harness. |
494667d to
663142e
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.html line 73 at r1 (raw file):
/> @if (signupForm.controls.translationLanguageName.hasError("required")) { <mat-error>{{ t("translation_language_name_required") }}</mat-error>
Is there a reason this needs to be specific. I would think it is better to just say "this field is required" since that translation is easy and shouldn't need to be updated.
Code quote:
<mat-error>{{ t("translation_language_name_required") }}</mat-error>663142e to
35fe654
Compare
35fe654 to
bd04a4a
Compare
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.html line 73 at r1 (raw file):
Previously, RaymondLuong3 (Raymond Luong) wrote…
Is there a reason this needs to be specific. I would think it is better to just say "this field is required" since that translation is easy and shouldn't need to be updated.
Done. Also added to other fields that were missing it. I went with just "Required" because I'm afraid non-native speakers might think of "an open land area free of woods and buildings" when reading "field".
Somehow I forgot to put error messages on two of the form fields.
Before
After
This change is