Skip to content

Add missing error messages to onboarding form - #3831

Open
Nateowami wants to merge 1 commit into
masterfrom
feature/onboarding-form-error-messages
Open

Add missing error messages to onboarding form#3831
Nateowami wants to merge 1 commit into
masterfrom
feature/onboarding-form-error-messages

Conversation

@Nateowami

@Nateowami Nateowami commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

Somehow I forgot to put error messages on two of the form fields.

Before

Screenshot from 2026-04-24 19-05-29

After

Screenshot from 2026-04-24 19-04-58
Open in Devin Review

This change is Reviewable

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.08%. Comparing base (99fe5e2) to head (bd04a4a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3831   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files         661      661           
  Lines       43058    43058           
  Branches     7036     7036           
=======================================
  Hits        34912    34912           
  Misses       6989     6989           
  Partials     1157     1157           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3
RaymondLuong3 force-pushed the feature/onboarding-form-error-messages branch from 494667d to 663142e Compare April 27, 2026 22:19

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).


src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.html line 73 at r1 (raw file):

                />
                @if (signupForm.controls.translationLanguageName.hasError("required")) {
                  <mat-error>{{ t("translation_language_name_required") }}</mat-error>

Is there a reason this needs to be specific. I would think it is better to just say "this field is required" since that translation is easy and shouldn't need to be updated.

Code quote:

<mat-error>{{ t("translation_language_name_required") }}</mat-error>

@RaymondLuong3 RaymondLuong3 self-assigned this Apr 27, 2026
@Nateowami
Nateowami force-pushed the feature/onboarding-form-error-messages branch from 663142e to 35fe654 Compare April 28, 2026 12:59
@Nateowami
Nateowami force-pushed the feature/onboarding-form-error-messages branch from 35fe654 to bd04a4a Compare August 13, 2026 20:54

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nateowami made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).


src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.html line 73 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Is there a reason this needs to be specific. I would think it is better to just say "this field is required" since that translation is easy and shouldn't need to be updated.

Done. Also added to other fields that were missing it. I went with just "Required" because I'm afraid non-native speakers might think of "an open land area free of woods and buildings" when reading "field".

@Nateowami
Nateowami deployed to screenshot_diff August 13, 2026 21:02 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants