Skip to content

SF-3116 Disallow whitespace notes - #4042

Merged
pmachapman merged 1 commit into
masterfrom
fix/SF-3116-disallow-white-space-notes
Aug 16, 2026
Merged

SF-3116 Disallow whitespace notes#4042
pmachapman merged 1 commit into
masterfrom
fix/SF-3116-disallow-white-space-notes

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.08%. Comparing base (71d9965) to head (9b87d76).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nslate/editor/note-dialog/note-dialog.component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4042   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files         661      661           
  Lines       43059    43060    +1     
  Branches     7062     7036   -26     
=======================================
+ Hits        34915    34916    +1     
- Misses       6972     6987   +15     
+ Partials     1172     1157   -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami
Nateowami deployed to screenshot_diff August 12, 2026 22:33 — with GitHub Actions Active
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Aug 13, 2026
@Nateowami
Nateowami marked this pull request as ready for review August 13, 2026 14:14
@pmachapman
pmachapman force-pushed the fix/SF-3116-disallow-white-space-notes branch from 03fcf1a to 9b87d76 Compare August 16, 2026 20:38

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@pmachapman
pmachapman deployed to screenshot_diff August 16, 2026 20:45 — with GitHub Actions Active
@pmachapman
pmachapman merged commit c2c311c into master Aug 16, 2026
28 checks passed
@pmachapman
pmachapman deleted the fix/SF-3116-disallow-white-space-notes branch August 16, 2026 20:49
@pmachapman pmachapman self-assigned this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants