Skip to content

SF-3899 Reduce size of onboarding requests list RPC response - #4044

Open
Nateowami wants to merge 1 commit into
masterfrom
feature/SF-3899-reduce-onboarding-request-rpc-response-size
Open

SF-3899 Reduce size of onboarding requests list RPC response#4044
Nateowami wants to merge 1 commit into
masterfrom
feature/SF-3899-reduce-onboarding-request-rpc-response-size

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Live currently returns 346kB and will only grow, but most of the size comes from fields that aren't needed for showing a list of requests.


This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Aug 13, 2026
@Nateowami
Nateowami deployed to screenshot_diff August 13, 2026 18:44 — with GitHub Actions Active
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.00%. Comparing base (99fe5e2) to head (0f94dc8).
⚠️ Report is 9 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/SIL.XForge.Scripture/Models/OnboardingRequest.cs 0.00% 33 Missing ⚠️
...boarding-requests/onboarding-requests.component.ts 0.00% 8 Missing ⚠️
...rge.Scripture/Services/OnboardingRequestService.cs 0.00% 7 Missing ⚠️
...ate/draft-generation/onboarding-request.service.ts 0.00% 1 Missing ⚠️
...ture/Controllers/OnboardingRequestRpcController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4044      +/-   ##
==========================================
- Coverage   81.08%   81.00%   -0.08%     
==========================================
  Files         661      661              
  Lines       43058    43097      +39     
  Branches     7036     7057      +21     
==========================================
  Hits        34912    34912              
- Misses       6989     7013      +24     
- Partials     1157     1172      +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

📸 Screenshot diff deployed! (1 change)

View the visual diff at: https://pr-4044--sf-screenshot-diffs.netlify.app

@pmachapman pmachapman self-assigned this Aug 16, 2026

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants