SF-2101 Fix errors continuing after project deletion dialog shown - #4046
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4046 +/- ##
=======================================
Coverage 81.08% 81.08%
=======================================
Files 661 661
Lines 43060 43061 +1
Branches 7062 7036 -26
=======================================
+ Hits 34916 34917 +1
- Misses 6972 6987 +15
+ Partials 1172 1157 -15 ☔ View full report in Codecov by Harness. |
Nateowami
added
testing complete
Nateowami
marked this pull request as ready for review
August 14, 2026 14:21
pmachapman
force-pushed
the
fix/SF-2101-deletion-dialog-allows-errors
branch
from
August 16, 2026 21:08
f12ae9f to
a44c302
Compare
pmachapman
approved these changes
Aug 16, 2026
pmachapman
left a comment
pmachapman
left a comment
Collaborator
There was a problem hiding this comment.
@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is