fix: adds tenant to context before check#686
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
Unheilbar,
pavel-raykov and
silaslenihan
MStreet3
commented
Jul 14, 2026
Comment on lines
+467
to
+471
| ctx = contexts.WithCRE(ctx, contexts.CRE{ | ||
| Org: orgID, | ||
| Owner: workflowOwner, | ||
| Workflow: workflowID, | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
Without this context, the flag check fails because no tenant is provided.
MStreet3
commented
Jul 14, 2026
| require.Equal(t, expectedWorkflowID, workflowIDFromResponse) | ||
|
|
||
| executionID, err := workflows.GenerateExecutionIDWithTriggerIndex(strings.TrimPrefix(workflowIDFromResponse, "0x"), requestID, 0) | ||
| executionID, err := workflows.EncodeExecutionID(strings.TrimPrefix(workflowIDFromResponse, "0x"), requestID) //nolint:staticcheck // SA1019 legacy execution ID path |
Contributor
Author
There was a problem hiding this comment.
have to revert this back to expect legacy ID by default
jmank88
approved these changes
Jul 14, 2026
mchain0
approved these changes
Jul 14, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-adds the flag because we cannot run in mixed mode without the flag, we need to roll this version out with flag with correct context added, then it can be removed in a subsequent release.