Skip to content

Always return query parameters - #21

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
always-return-query-parameters
Sep 7, 2026
Merged

Always return query parameters#21
samuel-williams-shopify merged 1 commit into
mainfrom
always-return-query-parameters

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Summary

  • make Reference#parse_query! create and return an empty mutable parameter hash when no query or parameters exist
  • document the behavior
  • verify mutations are retained by the reference and reflected by serialization

Testing

  • bundle exec bake test (391 tests, 573 assertions)
  • bundle exec rubocop lib/protocol/url/reference.rb test/protocol/url/reference.rb
  • bundle exec bake decode:index:coverage lib (101/101 documented)
  • git diff --check

Assisted-By: devx/7ef83274-928f-499d-b668-48449b1ff60e
@samuel-williams-shopify
samuel-williams-shopify merged commit a9d13be into main Sep 7, 2026
40 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the always-return-query-parameters branch September 7, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant