Repository navigation
Fix Japanese Qwen truncation and missing syllables - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #48. Japanese lines without spaces were given a 40-frame Qwen budget, cutting speech off around 3.2 seconds. Count CJK graphemes when budgeting and chunking speech, retain the selected language across engine fallbacks, and build against the corrected Qwen codec decoder so complete syllables survive reference separation and chunk boundaries.
Changes
src/so SwiftPM dependency tests cannot contaminate the suite.Test plan
.buildwas excluded while all 86 frontend tests passed.The model tests generate a matched macOS system-voice reference. No original speaker recording, project, or private logs are included. The separate CosyVoice symptom has no captured synthesis log and remains unconfirmed; this change does not claim to resolve it.