[FEATURE] Tag-based response cache for GET endpoints (#146)#147
Open
klamparski wants to merge 6 commits into
Open
[FEATURE] Tag-based response cache for GET endpoints (#146)#147klamparski wants to merge 6 commits into
klamparski wants to merge 6 commits into
Conversation
… failures OperationNotAllowedException's constructor could itself throw an unrelated exception (e.g. ArgumentCountError from TYPO3 core internals) whenever LocalizationUtility::translate() failed, masking the real access-denied error - and forced OperationResponseCacheTest::registerFakeTranslation() to fake TYPO3's translation machinery in increasingly TYPO3-version-specific ways (three distinct failure modes across TYPO3 12/13/14 point releases). Falling back to the raw translation key removes both problems at once.
…tibility SiteMatcher::getRouteCollectionForVeryFirstRequestPattern() called idn_to_ascii() on a site language's host without guarding against an empty value (e.g. a relative site base) - harmless on PHP 8.1-8.3, but PHP 8.4 made idn_to_ascii() throw ValueError on an empty argument. TYPO3 core added the missing guard in 12.4.18; our declared floor, 12.4.16, predates the fix. Bumped cms-core/cms-extbase/cms-frontend/cms-install together to keep the TYPO3 12 distribution's version floor consistent.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146