Skip to content

More strict error handling may be required in Monotonic #3

Description

@hnes

Hi, I am not good at golang's asm, but the implementation logic probably seems not so strict in the monotime/mono_linux_amd64.s:

  1. As the __vdso_clock_gettime_sym may not support CLOCK_MONOTONIC_RAW ($ man clock_gettime: since Linux 2.6.28; Linux-specific), so we should also check the ret status (EINVAL|EFAULT|EPERM).

  2. When vdso_is_sad is been executed, the monotime's ret is also invalid. But it seems that there does not have any checking codes in the go function Monotonic.

Thanks a lot.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions