Skip to content

Fix Example4 ExternalSpdxIds - #125

Merged
goneall merged 1 commit into
spdx:masterfrom
augelu-tng:fix-example4
Sep 24, 2026
Merged

goneall merged 1 commit into
spdx:masterfrom
augelu-tng:fix-example4

Conversation

@augelu-tng

@augelu-tng augelu-tng commented Nov 7, 2025 •

Copy link
Copy Markdown
Contributor

I think this should be how example4/spdx3.0 was intended. Please correct if I am wrong.
Resolves #124

@vargenau

Copy link
Copy Markdown
Contributor

@bact @goneall @kestewart
Can you please check if this pull request is correct and if so merge it?

I think the locationHint is also wrong in example5/spdx3.0/example5-bin.spdx3.json example4/spdx3.0/example4-bin.spdx3.json example3/spdx3.0/example3-bin.spdx3.json example6/spdx3.0/example6-bin.spdx3.json example7/spdx3.0/example7-bin.spdx3.json

@bact

bact commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

there are conflicts

@goneall

goneall commented Sep 18, 2026

Copy link
Copy Markdown
Member

@augelu-tng - Sorry I missed this earlier - I think you are correct that the current example incorrectly references the SPDX 2 documents.

If you get a chance, can you resolve the merge conflicts then ping me - I'll review and merge.

Signed-off-by: Luis Augenstein <luis.augenstein@tngtech.com>
@augelu-tng

Copy link
Copy Markdown
Contributor Author

@goneall I fixed the merge conflict.

@goneall
goneall merged commit c19ae79 into spdx:master Sep 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect SPDX v2.3 → v3.0 external references in example4-bin.json

4 participants