Repository navigation
Conversation
Collaborator
|
It looks like this PR will need to be rebased -- the JSON reader has had some updates. |
Signed-off-by: ajayk <ajaykemparaj@gmail.com>
ajayk
force-pushed
the
perf/json-roundtrips
branch
from
October 1, 2026 02:30
501d8f7 to
89e926a
Compare
Author
|
@kzantow can you please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON reading currently builds a generic object tree for the entire document to inspect
spdxVersion, then decodes it again into the versioned model. SPDX 2.2 package serialization also encodes, decodes, and re-encodes each package when its verification code is absent.Keep top-level JSON fields as
json.RawMessageduring version detection and omit empty verification codes through a shadowing pointer field. This removes the temporary object tree and the serialization round trip. Public APIs and JSON values remain unchanged; serialized object key order can change.Adds repeatable benchmarks and regression coverage for supported versions, version errors, malformed input, reader errors, verification-code omission, nested fields, HTML escaping, and marshal errors.
Local benchmark medians over five runs on Apple M5 Pro, darwin/arm64, Go 1.27.1:
The verification-code-present control retains the same allocations and bytes, with approximately unchanged timing in longer repeat runs.
Validation:
make testpasses, including both existing 100,000-input fuzz runs. Regression tests also pass against the original implementation.Reproduce benchmarks: