fix(core/structure): propagate custom heading ID to section element - #5281
Draft
marcoscaceres wants to merge 3 commits into
Draft
fix(core/structure): propagate custom heading ID to section element#5281marcoscaceres wants to merge 3 commits into
marcoscaceres wants to merge 3 commits into
Conversation
When a heading has a custom ID (e.g., from {#custom-id} markdown
syntax), move it to the wrapping section element instead of generating
a separate auto-ID from the heading text. This ensures section and
heading share one canonical ID for fragment navigation and tools
like webref that expect section-level IDs.
Closes #4947
Contributor
Author
|
@copilot can you fix whatever is causing CI to fail? |
Contributor
Fixed in 9bfe25f. I investigated the failing Node CI run and updated the affected core specs to match the new heading-id-to-section-id behavior, which resolves the reported failing tests. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
Author
|
The change this PR makes (moving the author's heading id onto the section, and generating a fresh section-number-based id for the heading) does not reduce the number of ids emitted; it swaps which element holds the author's one, and changes the ids in every ReSpec document. The reason it was worth doing, that webref omitted the custom id, no longer applies: w3c/reffy#1824 landed and webref now exposes it as |
Contributor
Author
|
Reopening: I closed this too early. The close reasoning was that the reported breakage is gone, since w3c/reffy#1824 landed and webref now exposes the author's id as Where this PR differs from his suggestion is the heading's generated id. This PR leaves it to be generated from the numbered heading text, which is the So the open question is whether to adopt that reserved prefix here. Worth noting either way: this changes the ids emitted by every ReSpec document, and @tabatkins' original question was why a second id is generated at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4947
When a heading has an explicit id and its section has none, move
the id from the heading to the section.
Written with AI: this change was generated by Claude. Per AI_POLICY.md.