fix(core/caniuse): use dl markup and CSS Grid layout - #5282
Draft
marcoscaceres wants to merge 3 commits into
Draft
fix(core/caniuse): use dl markup and CSS Grid layout#5282marcoscaceres wants to merge 3 commits into
marcoscaceres wants to merge 3 commits into
Conversation
Replaces div-based layout with semantic dl (dt for browser type, dd for browser cells). Switches from flexbox to CSS Grid with auto-fit columns. More info link gets its own row. Closes #4090
The dl's direct children (dt, dd) were being placed as individual grid items, interleaving labels with browser cells instead of grouping them vertically. Wrapping each pair in a div.caniuse-group makes the grid operate on logical groups. Also updates tests to query the new selectors.
marcoscaceres
force-pushed
the
fix/4090-caniuse-grid
branch
from
May 14, 2026 15:22
dddb892 to
54a01af
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks Can I Use output with semantic definition-list markup and responsive CSS Grid layout.
Changes:
- Uses
dl/dt/ddmarkup for browser groups. - Moves “More info” onto its own row.
- Updates styles and tests for the new structure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/core/caniuse.js |
Generates semantic grouped markup. |
src/styles/caniuse.css.js |
Adds responsive grid layout. |
tests/spec/core/caniuse-spec.js |
Updates selectors and expectations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+227
to
+228
| expect(desktop.querySelector(".caniuse-type").textContent).toBe("desktop"); | ||
| expect(mobile.querySelector(".caniuse-type").textContent).toBe("mobile"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4090
Replace div-based caniuse layout with semantic dl markup and CSS Grid.
Each dt/dd pair is wrapped in a div.caniuse-group for correct grid
column behavior.
Written with AI: this change was generated by Claude. Per AI_POLICY.md.