Repository navigation
feat: ignore trivial keyboard overlap from fractional view sizes - #4
Merged
Merged
Conversation
johnnewman-square
marked this pull request as ready for review
February 24, 2026 19:46
kyleve
reviewed
Feb 24, 2026
kyleve
approved these changes
Feb 24, 2026
Replaces `frame.intersects(view.bounds)` with a dimension-based check that requires at least 1pt of overlap in both width and height. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
johnnewman-square
force-pushed
the
johnnewman/task/fractional-view-sizes
branch
from
February 25, 2026 14:34
93c5b04 to
1116ce2
Compare
johnnewman-square
changed the base branch from
johnnewman/task/additional-tests
to
main
February 25, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
frame.intersects(view.bounds)with a dimension-based check that requires at least 1pt of overlap in both width and height. This avoids cases where the keyboard may be overhanging the view by a fraction of a screen point, which was eagerly detected as overlap.