Issues with magit 4.3.5 and magit-stgit 20250215.2223

[cpg314]

It seems like something is broken with

Magit v4.3.5, Transient 0.8.6, Git 2.49.0, Emacs 30.1, gnu/linux
magit-stgit                    20250215.2223  available    melpa    StGit extension for Magit

Create a simple 2-patch series:

~/tmp (master|✔) $ stg series
+ initial
> blah

but magit shows

Patch series (1)
 +  initial initial

Recent commits
33fa365 master 
28ad253 initial
63a1991 iff

*> blah    #

Pressing ENTER on the first patch gives

funcall-interactively: Wrong number of arguments: #<subr magit-stgit-show>, 7

while pressing a gives

shell-quote-argument: Wrong type argument: sequencep, 105

[llvilanova]

I hit the same problem. The solution is to replace (append (magit-stgit-read-patch prompt require-match) nil) in magit-stgit-read-patches with (list (magit-stgit-read-patch prompt require-match)).

[tarsius]

I think both magit-stgit-read-patches and its use in magit-stgit-show are broken. Please test the fix-21 branch. There is a risk that the first commit breaks other uses of magit-stgit-read-patches, but only if they have another bug that used to cancel out the bug in magit-stgit-read-patches, but it appears that is not the case. However, I am not able to test it, because I don't use stgit, so I'll have to wait for you to test it (please try a bunch of commands, which use this function).

[tarsius]

By the way, does anyone currently consider themselves the maintainer? I intend to give up my permissions for this repository and unsubscribe, once this issue has been resolved.