Skip to content

Rename save_latent_dynamics to save_diagnostics - #876

Merged
WardBrian merged 1 commit into
developfrom
fix/872-save-diagnostics
Nov 2, 2026
Merged

WardBrian merged 1 commit into
developfrom
fix/872-save-diagnostics

Conversation

@WardBrian

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #872

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian
WardBrian requested a review from amas0 November 2, 2026 15:54
@WardBrian

Copy link
Copy Markdown
Member Author

The pylint failure is confusing to me, because there certainly isn't a mention of save_latent_dynamics on that line...

@amas0

amas0 commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Can you check to see if you branched off develop before your local version had #870 merged in? When I pulled locally it looked like the commit history wasn't the same? Maybe try a rebase onto head?

@WardBrian
WardBrian force-pushed the fix/872-save-diagnostics branch from 00ed8a0 to 94d1e2e Compare November 2, 2026 17:41
@WardBrian
WardBrian merged commit c8164f9 into develop Nov 2, 2026
39 of 40 checks passed
@WardBrian
WardBrian deleted the fix/872-save-diagnostics branch November 2, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename save_latent_dynamics to save_diagnostics for consistency

2 participants