Sends billing.events log lines to S3 - #2522
Open
Hazel-Datastax wants to merge 69 commits into
Open
Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
erichare
self-requested a review
September 1, 2026 17:46
erichare
reviewed
Sep 1, 2026
erichare
reviewed
Sep 1, 2026
erichare
reviewed
Sep 1, 2026
erichare
reviewed
Sep 1, 2026
erichare
reviewed
Sep 1, 2026
4 tasks
still needs decisions on what to do when upload fails. Installer setup to do basic starting of the uploader.
erichare
reviewed
Sep 4, 2026
erichare
reviewed
Sep 4, 2026
erichare
reviewed
Sep 4, 2026
erichare
reviewed
Sep 4, 2026
erichare
reviewed
Sep 4, 2026
erichare
reviewed
Sep 4, 2026
erichare
reviewed
Sep 4, 2026
erichare
reviewed
Sep 4, 2026
| * billing.events} JUL logger, the disabled path, and fail-loud startup on bad config. Delivery | ||
| * through an installed handler is covered by {@code BillingS3ExportIntegrationTest}. | ||
| */ | ||
| class BillingS3HandlerInstallerTest { |
erichare
reviewed
Sep 4, 2026
| * flush()/notify() on an object lands before the upload thread is in wait() - if we used | ||
| * Object.notify() and .wait() | ||
| */ | ||
| private final Semaphore wakeupPermit = new Semaphore(0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Uses a buffer to batch up the logging messages for billing events, and sends to S3 when configured.
Start with the BillingS3HandlerInstaller and follow from there.
Which issue(s) this PR fixes:
Fixes #
Checklist