Skip to content

[6.x] Append entry to structure tree directly when duplicating entry with root as parent - #11320

Open
Boefjim wants to merge 3 commits into
statamic:6.xfrom
Boefjim:5.x
Open

Boefjim wants to merge 3 commits into
statamic:6.xfrom
Boefjim:5.x

Conversation

@Boefjim

@Boefjim Boefjim commented Jan 7, 2025 •

Copy link
Copy Markdown
Contributor

Closes #11319

Changes

  • Added it_adds_duplicated_entry_to_tree case to DuplicateEntry action tests
  • Appended entry to structure even when original has no parent

@Boefjim

Boefjim commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

@jasonvarga Could you maybe take a look at this?
Duplications causing an invalid tree has been giving us some troubles for a little while now, so we hope this could be merged soon 😅

@Boefjim

Boefjim commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

I've added a test case for the functionality this addresses, if you checkout that commit (before the fix), you can see that the duplicated entry is missing from the tree structure.
Hopefully this helps in reviewing the changes are correct.

@duncanmcclean duncanmcclean changed the title [5.x] Append entry to structure tree directly when duplicating entry with root as parent [6.x] Append entry to structure tree directly when duplicating entry with root as parent Jan 28, 2026
@duncanmcclean
duncanmcclean changed the base branch from 5.x to 6.x January 28, 2026 17:33
@Boefjim

Boefjim commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

@duncanmcclean Is there something missing that is preventing this from being reviewed?

@duncanmcclean

Copy link
Copy Markdown
Member

Nope, we just haven't got around to reviewing it yet. We'll get to it when we can.

In the meantime, you can pull this PR into your project with a composer patch.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated entries do not get appended to tree file when parent is root

2 participants