Repository navigation
[6.x] Fix saving untouched navigation defaults - #15926
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-2c731f04-3b24-40ea-8084-640ef46ef602 Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
Amp-Thread-ID: https://ampcode.com/threads/T-8c6e271f-0a73-4bee-a376-0a43e4afce19 Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where default values in navigation blueprints weren't saved unless the fields were changed.
This was happening because saving a navigation tree only kept fields marked as localized, even for nav items that don't link to an entry.
This PR fixes it by saving all submitted fields for regular nav items, while keeping localized-field filtering for entry links so they continue to inherit their entry's values. This follows the same inheritance distinction used by entries, terms, and globals.
Tested through the sandbox control panel before and after the fix, including new and existing nav items, explicit overrides, and entry-link inheritance. The navigation feature tests pass, with one pre-existing incomplete test.
Fixes #9423
https://ampcode.com/threads/T-2c731f04-3b24-40ea-8084-640ef46ef602