Skip to content

[6.x] Fix saving untouched navigation defaults - #15926

Merged
duncanmcclean merged 2 commits into
6.xfrom
9423
Nov 16, 2026
Merged

duncanmcclean merged 2 commits into
6.xfrom
9423

Conversation

@duncanmcclean

Copy link
Copy Markdown
Member

This pull request fixes an issue where default values in navigation blueprints weren't saved unless the fields were changed.

This was happening because saving a navigation tree only kept fields marked as localized, even for nav items that don't link to an entry.

This PR fixes it by saving all submitted fields for regular nav items, while keeping localized-field filtering for entry links so they continue to inherit their entry's values. This follows the same inheritance distinction used by entries, terms, and globals.

Tested through the sandbox control panel before and after the fix, including new and existing nav items, explicit overrides, and entry-link inheritance. The navigation feature tests pass, with one pre-existing incomplete test.

Fixes #9423

https://ampcode.com/threads/T-2c731f04-3b24-40ea-8084-640ef46ef602

ampagent and others added 2 commits November 16, 2026 14:25
Amp-Thread-ID: https://ampcode.com/threads/T-2c731f04-3b24-40ea-8084-640ef46ef602
Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
@duncanmcclean
duncanmcclean merged commit 021cb64 into 6.x Nov 16, 2026
64 checks passed
@duncanmcclean
duncanmcclean deleted the 9423 branch November 16, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default values in navigation blueprints don't save

2 participants