Repository navigation
[6.x] Fix site filter not updating after switching sites - #15931
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1e4cb-c498-71f6-b724-95d1ede5e3a0 Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the entries listing kept showing the previously selected site after switching sites using the global site selector.
This was happening because the listing pushes its filters (including the site filter) into the URL. When selecting a site, we redirect back to the previous URL, so the listing re-applied the old site filter over the newly selected site.
This PR fixes it by switching the site filter in the previous URL to the newly selected site before redirecting back.
Amp thread: https://ampcode.com/threads/T-01a1e4cb-c498-71f6-b724-95d1ede5e3a0
Fixes #11557