Feature/messages scroll persistence - #178
Merged
Merged
Conversation
Add SavedScroll state and messages_reset_for_session to MessagesView so that switching sessions saves/restores the logical scroll anchor and follow-tail flag, and a same-session resync freezes the visible offset instead of jumping to the bottom.
Route notify_messages_reset and remove_empty_containers through MessagesView::messages_reset_for_session with the current session id, so that: - switching sessions restores each session's remembered scroll position and follow-tail state, - a same-session resync (stream lag, file-watcher refresh, structural edit) freezes the visible offset instead of snapping to the bottom. Session deletion forgets the remembered scroll for that session.
The instant jump-to-bottom used ListState::scroll_to_reveal_item, which computes a pixel target from item heights. Right after reset() the list items are unmeasured (zero height), so it landed at the TOP — visible when returning to a long session that was scrolled to the end. Use ListState::scroll_to_end instead: it anchors past the last item so the layout pass walks backwards from the end and reveals the true bottom regardless of measurement state. Also keep a following session pinned to the end across the height-cache remeasures. Adds a regression test asserting a follow-tail restore anchors past the last item.
Store the scroll anchor + follow-tail flag in the existing per-session UiSessionState (the same <session>.ui_state.json that already holds tool collapse/diff overrides), so a session is shown as it was left across app restarts. Writes are throttled through the existing debounced PersistUiState flush: persist_current_scroll records the current position on real user scroll (wheel handler), on the edge-drag follow-tail transition, on the scroll-to-bottom button, and on session switch. A no-op guard in UiStateStore::set_scroll avoids re-dirtying on unchanged positions. Restore prefers the in-memory per-run position and falls back to the on-disk position (load_persisted_scroll). Adds UiStateStore scroll get/set + serialization tests.
Remove the standalone MessagesView::messages_reset — its reset-to-bottom logic overlapped with the session-aware path. The delete/disconnect call site and the two unit tests now use messages_reset_for_session(None, ...), which clears to the empty state via the same-session branch (the displayed session is cleared first, so no stale scroll is restored).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.